From c962bd0abffa04c19e32ed824bfe4bb5b515fb0d Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Thu, 24 Aug 2023 08:33:58 -0700 Subject: [PATCH] terminal/kitty-gfx: add error if both image id and num is set --- src/terminal/kitty/graphics_exec.zig | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/terminal/kitty/graphics_exec.zig b/src/terminal/kitty/graphics_exec.zig index fb6b835f7..5b3454f9b 100644 --- a/src/terminal/kitty/graphics_exec.zig +++ b/src/terminal/kitty/graphics_exec.zig @@ -120,6 +120,9 @@ fn transmit( .image_number = t.image_number, .placement_id = t.placement_id, }; + if (t.image_id > 0 and t.image_number > 0) { + return .{ .message = "EINVAL: image ID and number are mutually exclusive" }; + } const load = loadAndAddImage(alloc, terminal, cmd) catch |err| { encodeError(&result, err); @@ -244,6 +247,8 @@ fn delete( ) Response { const storage = &terminal.screen.kitty_images; storage.delete(alloc, terminal, cmd.control.delete); + + // Delete never responds on success return .{}; }