Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-17 09:16:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

font/coretext: better comment coretext shaper

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-04-04 12:06:59 -07:00
parent 61d3da1bf6
commit c5bbbdb5ee
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/font/shaper/coretext.zig
View File

@ -18,13 +18,17 @@ const log = std.log.scoped(.font_shaper);
/// Shaper that uses CoreText. /// Shaper that uses CoreText.
/// ///
/// WARNING: This is not ready for production usage. This is why this shaper /// CoreText shaping differs in subtle ways from HarfBuzz so it may result
/// can't be configured at build-time without modifying the source. There are /// in inconsistent rendering across platforms. But it also fixes many
/// a couple major missing features (quirks mode, font features) and I haven't /// issues (some macOS specific):
/// very carefully audited all my memory management. ///
/// - Theta hat offset is incorrect in HarfBuzz but correct by default
/// on macOS applications using CoreText. (See:
/// https://github.com/harfbuzz/harfbuzz/discussions/4525)
///
/// - Hyphens (U+2010) can be synthesized by CoreText but not by HarfBuzz.
/// See: https://github.com/mitchellh/ghostty/issues/1643
/// ///
/// The purpose of this shaper is to keep us honest with our other shapers
/// and to help us find bugs in our other shapers.
pub const Shaper = struct { pub const Shaper = struct {
/// The allocated used for the feature list and cell buf. /// The allocated used for the feature list and cell buf.
alloc: Allocator, alloc: Allocator,
@ -197,7 +201,8 @@ pub const Shaper = struct {
defer arena.deinit(); defer arena.deinit();
const alloc = arena.allocator(); const alloc = arena.allocator();
// Get our font // Get our font. We have to apply the font features we want for
// the font here.
const run_font: *macos.text.Font = font: { const run_font: *macos.text.Font = font: {
const face = try run.group.group.faceFromIndex(run.font_index); const face = try run.group.group.faceFromIndex(run.font_index);
const original = face.font; const original = face.font;