From 018a888578acf7a9c70fdb0035d3ec3b4ce28276 Mon Sep 17 00:00:00 2001
From: AltCode <12354672+AlternateRT@users.noreply.github.com>
Date: Fri, 17 Jan 2025 15:18:22 +0100
Subject: [PATCH] macOS: add link to release notes on appcast

---
 dist/macos/update_appcast_tag.py | 11 +++++++----
 dist/macos/update_appcast_tip.py |  4 ++--
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/dist/macos/update_appcast_tag.py b/dist/macos/update_appcast_tag.py
index 4ef526019..6abfb66db 100644
--- a/dist/macos/update_appcast_tag.py
+++ b/dist/macos/update_appcast_tag.py
@@ -21,6 +21,7 @@ from datetime import datetime, timezone
 
 now = datetime.now(timezone.utc)
 version = os.environ["GHOSTTY_VERSION"]
+version_dash = version.replace('.', '-')
 build = os.environ["GHOSTTY_BUILD"]
 commit = os.environ["GHOSTTY_COMMIT"]
 commit_long = os.environ["GHOSTTY_COMMIT_LONG"]
@@ -82,18 +83,20 @@ elem = ET.SubElement(item, "sparkle:shortVersionString")
 elem.text = f"{version}"
 elem = ET.SubElement(item, "sparkle:minimumSystemVersion")
 elem.text = "13.0.0"
+elem = ET.SubElement(item, "sparkle:fullReleaseNotesLink")
+elem.text = f"https://ghostty.org/docs/install/release-notes/{version_dash}"
 elem = ET.SubElement(item, "description")
 elem.text = f"""
-<h1>Ghostty v{version}</h1>
+<![CDATA[<h1>Ghostty v{version}</h1>
 <p>
 This release was built from commit <code><a href="{repo}/commits/{commit_long}">{commit}</a></code>
 on {now.strftime('%Y-%m-%d')}.
 </p>
 <p>
 We don't currently generate release notes for auto-updates.
-You can view the complete changelog and release notes on
-the <a href="https://ghostty.org">Ghostty website</a>.
-</p>
+You can view the complete changelog and release notes
+at <a href="https://ghostty.org/docs/install/release-notes/{version_dash}">ghostty.org/docs/install/release-notes/{version_dash}</a>.
+</p>]]>
 """
 elem = ET.SubElement(item, "enclosure")
 elem.set("url", f"https://release.files.ghostty.org/{version}/Ghostty.dmg")
diff --git a/dist/macos/update_appcast_tip.py b/dist/macos/update_appcast_tip.py
index ff1fb4be5..c6a20f75f 100644
--- a/dist/macos/update_appcast_tip.py
+++ b/dist/macos/update_appcast_tip.py
@@ -83,7 +83,7 @@ elem = ET.SubElement(item, "sparkle:minimumSystemVersion")
 elem.text = "13.0.0"
 elem = ET.SubElement(item, "description")
 elem.text = f"""
-<p>
+<![CDATA[<p>
 Automated build from commit <code><a href="{repo}/commits/{commit_long}">{commit}</a></code>
 on {now.strftime('%Y-%m-%d')}.
 </p>
@@ -91,7 +91,7 @@ on {now.strftime('%Y-%m-%d')}.
 These are automatic per-commit builds generated from the main Git branch.
 We do not generate any release notes for these builds. You can view the full
 commit history <a href="{repo}">on GitHub</a> for all changes.
-</p>
+</p>]]>
 """
 elem = ET.SubElement(item, "enclosure")
 elem.set("url", f"https://tip.files.ghostty.org/{commit_long}/Ghostty.dmg")