Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1131 from mitchellh/chinese-quotes

Browse Source 
apprt/gtk: only reset IME state if key consuming while IME composing
This commit is contained in:
Mitchell Hashimoto
2023-12-19 22:10:13 -08:00
committed by GitHub
parent 0eab07b014 0c80f85d78
commit bfd0baf78f
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/apprt/gtk/Surface.zig
View File

@ -1482,10 +1482,15 @@ fn keyEvent(
.closed => return true, .closed => return true,
.ignored => {}, .ignored => {},
.consumed => if (action == .press or action == .repeat) { .consumed => if (action == .press or action == .repeat) {
// If we consume the key then we want to reset the dead key // If we were in the composing state then we reset our context.
// state. // We do NOT want to reset if we're not in the composing state
c.gtk_im_context_reset(self.im_context); // because there is other IME state that we want to preserve,
self.core_surface.preeditCallback(null) catch {}; // such as quotation mark ordering for Chinese input.
if (self.im_composing) {
c.gtk_im_context_reset(self.im_context);
self.core_surface.preeditCallback(null) catch {};
}
return true; return true;
}, },
} }