Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: deleteLines with zero count should do nothing

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-03-19 11:50:31 -07:00
parent 56feeb28a8
commit b8d88fd8a2
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/terminal/Terminal.zig
View File

@ -1353,6 +1353,9 @@ pub fn insertLines(self: *Terminal, count: usize) void {
/// ///
/// Moves the cursor to the left margin. /// Moves the cursor to the left margin.
pub fn deleteLines(self: *Terminal, count_req: usize) void { pub fn deleteLines(self: *Terminal, count_req: usize) void {
// Rare, but happens
if (count_req == 0) return;
// If the cursor is outside the scroll region we do nothing. // If the cursor is outside the scroll region we do nothing.
if (self.screen.cursor.y < self.scrolling_region.top or if (self.screen.cursor.y < self.scrolling_region.top or
self.screen.cursor.y > self.scrolling_region.bottom or self.screen.cursor.y > self.scrolling_region.bottom or
@ -5719,6 +5722,16 @@ test "Terminal: deleteLines left/right scroll region high count" {
} }
} }
test "Terminal: deleteLines zero" {
const alloc = testing.allocator;
var t = try init(alloc, .{ .cols = 2, .rows = 5 });
defer t.deinit(alloc);
// This should do nothing
t.setCursorPos(1, 1);
t.deleteLines(0);
}
test "Terminal: default style is empty" { test "Terminal: default style is empty" {
const alloc = testing.allocator; const alloc = testing.allocator;
var t = try init(alloc, .{ .rows = 5, .cols = 5 }); var t = try init(alloc, .{ .rows = 5, .cols = 5 });