From e28d20a05d543f152ce714213b9072525c0ad795 Mon Sep 17 00:00:00 2001
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com>
Date: Thu, 2 Mar 2023 12:55:46 -0800
Subject: [PATCH 1/3] disable the auto balance config by default, add some
 padding

This makes resizing too jittery which I think is a worse out of the box
experience than the padding.
---
 src/config.zig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/config.zig b/src/config.zig
index b0e13e1e8..36761bd86 100644
--- a/src/config.zig
+++ b/src/config.zig
@@ -119,8 +119,8 @@ pub const Config = struct {
     /// the grid will be completely squished by the padding. It is up to you
     /// as the user to pick a reasonable value. If you pick an unreasonable
     /// value, a warning will appear in the logs.
-    @"window-padding-x": u32 = 0,
-    @"window-padding-y": u32 = 0,
+    @"window-padding-x": u32 = 2,
+    @"window-padding-y": u32 = 2,
 
     /// The viewport dimensions are usually not perfectly divisible by
     /// the cell size. In this case, some extra padding on the end of a
@@ -134,7 +134,7 @@ pub const Config = struct {
     /// still apply. The other padding is applied first and may affect how
     /// many grid cells actually exist, and this is applied last in order
     /// to balance the padding given a certain viewport size and grid cell size.
-    @"window-padding-balance": bool = true,
+    @"window-padding-balance": bool = false,
 
     /// If true, new windows and tabs will inherit the font size of the previously
     /// focused window. If no window was previously focused, the default

From 5573df4947425fd24abda1eec398807a5aefff6c Mon Sep 17 00:00:00 2001
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com>
Date: Thu, 2 Mar 2023 13:20:06 -0800
Subject: [PATCH 2/3] terminal: erase display complete needs to reset row wrap
 state

---
 src/terminal/Terminal.zig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/terminal/Terminal.zig b/src/terminal/Terminal.zig
index b67ab58b7..37535769e 100644
--- a/src/terminal/Terminal.zig
+++ b/src/terminal/Terminal.zig
@@ -904,7 +904,11 @@ pub fn eraseDisplay(
     switch (mode) {
         .complete => {
             var it = self.screen.rowIterator(.active);
-            while (it.next()) |row| row.clear(self.screen.cursor.pen);
+            while (it.next()) |row| {
+                row.setWrapped(false);
+                row.setDirty(true);
+                row.clear(self.screen.cursor.pen);
+            }
 
             // Unsets pending wrap state
             self.screen.cursor.pending_wrap = false;

From 4ececc8923240e0f68094086f8d19311be81fa8f Mon Sep 17 00:00:00 2001
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com>
Date: Thu, 2 Mar 2023 13:46:58 -0800
Subject: [PATCH 3/3] screen: resize rows should use old cols value

---
 src/terminal/Screen.zig | 42 +++++++++++++++++++++++++++++++++++++++--
 1 file changed, 40 insertions(+), 2 deletions(-)

diff --git a/src/terminal/Screen.zig b/src/terminal/Screen.zig
index a8c798d93..dd1e7b223 100644
--- a/src/terminal/Screen.zig
+++ b/src/terminal/Screen.zig
@@ -1985,12 +1985,12 @@ pub fn resize(self: *Screen, rows: usize, cols: usize) !void {
 
     // We grow rows after cols so that we can do our unwrapping/reflow
     // before we do a no-reflow grow.
-    if (rows > self.rows) try self.resizeWithoutReflow(rows, cols);
+    if (rows > self.rows) try self.resizeWithoutReflow(rows, self.cols);
 
     // If our rows got smaller, we trim the scrollback. We do this after
     // handling cols growing so that we can save as many lines as we can.
     // We do it before cols shrinking so we can save compute on that operation.
-    if (rows < self.rows) try self.resizeWithoutReflow(rows, cols);
+    if (rows < self.rows) try self.resizeWithoutReflow(rows, self.cols);
 
     // If our cols got smaller, we have to reflow text. This is the worst
     // possible case because we can't do any easy tricks to get reflow,
@@ -4905,6 +4905,44 @@ test "Screen: resize less cols with reflow previously wrapped and scrollback" {
     try testing.expectEqual(@as(usize, 2), s.cursor.y);
 }
 
+test "Screen: resize more rows, less cols with reflow with scrollback" {
+    const testing = std.testing;
+    const alloc = testing.allocator;
+
+    var s = try init(alloc, 3, 5, 3);
+    defer s.deinit();
+    const str = "1ABCD\n2EFGH3IJKL\n4MNOP";
+    try s.testWriteString(str);
+
+    {
+        var contents = try s.testString(alloc, .screen);
+        defer alloc.free(contents);
+        const expected = "1ABCD\n2EFGH\n3IJKL\n4MNOP";
+        try testing.expectEqualStrings(expected, contents);
+    }
+    {
+        var contents = try s.testString(alloc, .viewport);
+        defer alloc.free(contents);
+        const expected = "2EFGH\n3IJKL\n4MNOP";
+        try testing.expectEqualStrings(expected, contents);
+    }
+
+    try s.resize(10, 2);
+
+    {
+        var contents = try s.testString(alloc, .viewport);
+        defer alloc.free(contents);
+        const expected = "BC\nD\n2E\nFG\nH3\nIJ\nKL\n4M\nNO\nP";
+        try testing.expectEqualStrings(expected, contents);
+    }
+    {
+        var contents = try s.testString(alloc, .screen);
+        defer alloc.free(contents);
+        const expected = "1A\nBC\nD\n2E\nFG\nH3\nIJ\nKL\n4M\nNO\nP";
+        try testing.expectEqualStrings(expected, contents);
+    }
+}
+
 // This seems like it should work fine but for some reason in practice
 // in the initial implementation I found this bug! This is a regression
 // test for that.