Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #208 from mitchellh/mrn/locale-lang

Browse Source 
locale: set LANG to fallback locale
This commit is contained in:
Mitchell Hashimoto
2023-07-18 22:08:15 -07:00
committed by GitHub
parent c9b0c42341 5472d03832
commit b49dd6e3b7
1 changed files with 9 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/os/locale.zig
View File

@ -35,16 +35,17 @@ pub fn ensureLocale() void {
// If the locale is valid, we also use "" because LANG is already set. // If the locale is valid, we also use "" because LANG is already set.
if (localeIsValid(new_lang)) break :locale ""; if (localeIsValid(new_lang)) break :locale "";
// If the locale is not valid, and our lang changed, then we reset // If the locale is not valid we fall back to en_US.UTF-8 and need to
// to the old value. // set LANG to this value too.
if (!std.mem.eql(u8, lang, new_lang)) { const default_locale = "en_US.UTF-8";
if (setenv("LANG", lang.ptr, 1) < 0) { log.info("LANG is not valid according to libc, will use en_US.UTF-8", .{});
log.err("error resetting locale env var", .{});
} if (setenv("LANG", default_locale.ptr, 1) < 0) {
log.err("error setting LANG env var to {s}", .{default_locale});
} }
log.info("LANG is not valid according to libc, will use en_US.UTF-8", .{}); // Use it as locale
break :locale "en_US.UTF-8"; break :locale default_locale;
}; };
// Set the locale // Set the locale
@ -64,20 +65,6 @@ fn localeIsValid(locale: []const u8) bool {
/// This sets the LANG environment variable based on the macOS system /// This sets the LANG environment variable based on the macOS system
/// preferences selected locale settings. /// preferences selected locale settings.
fn setLangFromCocoa() void { fn setLangFromCocoa() void {
// Unknown Zig bug where in debug mode we can't pull the cocoa
// value without crashing so we just force it to en_US.UTF-8.
// Debug mode is only used for testing so to avoid this, devs can
// just set LANG manually!
if (builtin.mode == .Debug) {
log.warn("in debug mode, we always set LANG to en_US.UTF-8 if not set", .{});
if (setenv("LANG", "en_US.UTF-8", 1) < 0) {
log.err("error setting locale env var", .{});
return;
}
return;
}
const pool = objc.AutoreleasePool.init(); const pool = objc.AutoreleasePool.init();
defer pool.deinit(); defer pool.deinit();