Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-25 05:06:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

renderer/metal: do not update frames if cells don't change

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-05-03 21:12:04 -07:00
parent 92caea6948
commit b00e7009d7
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/renderer/Metal.zig
View File

@ -101,6 +101,11 @@ cells: mtl_cell.Contents,
/// If this is true, we do a full cell rebuild on the next frame. /// If this is true, we do a full cell rebuild on the next frame.
cells_rebuild: bool = true, cells_rebuild: bool = true,
/// Set to true after rebuildCells is called. This can be used
/// to determine if any possible changes have been made to the
/// cells for the draw call.
cells_rebuilt: bool = false,
/// The current GPU uniform values. /// The current GPU uniform values.
uniforms: mtl_shaders.Uniforms, uniforms: mtl_shaders.Uniforms,
@ -968,6 +973,12 @@ pub fn updateFrame(
pub fn drawFrame(self: *Metal, surface: *apprt.Surface) !void { pub fn drawFrame(self: *Metal, surface: *apprt.Surface) !void {
_ = surface; _ = surface;
// If our cells are not rebuilt, do a no-op draw. This means
// that no possible new data can exist that would warrant a full
// GPU update, our existing drawable is valid.
if (!self.cells_rebuilt) return;
self.cells_rebuilt = false;
// Wait for a frame to be available. // Wait for a frame to be available.
const frame = self.gpu_state.nextFrame(); const frame = self.gpu_state.nextFrame();
errdefer self.gpu_state.releaseFrame(); errdefer self.gpu_state.releaseFrame();
@ -1988,6 +1999,9 @@ fn rebuildCells(
// We always mark our rebuild flag as false since we're done. // We always mark our rebuild flag as false since we're done.
self.cells_rebuild = false; self.cells_rebuild = false;
// Update that our cells rebuilt
self.cells_rebuilt = true;
// Log some things // Log some things
// log.debug("rebuildCells complete cached_runs={}", .{ // log.debug("rebuildCells complete cached_runs={}", .{
// self.font_shaper_cache.count(), // self.font_shaper_cache.count(),