From d94cf2f12420b5a5ad5b3215a4cbfa383e6b45df Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Wed, 13 Sep 2023 11:34:06 -0700 Subject: [PATCH] remove flatpak Flatpak support has been a HUGE pain to keep working, the builds take forever and cost me real money, and there are very few users. Ideally, we want to just use native system packagers for each distro. I thought Flatpak would make it easy to support many distros but that ended up being false. --- .github/workflows/release-tip.yml | 48 +------------------------------ README.md | 3 +- com.mitchellh.ghostty.yml | 3 ++ dist/linux/app-flatpak.desktop | 14 --------- 4 files changed, 5 insertions(+), 63 deletions(-) delete mode 100644 dist/linux/app-flatpak.desktop diff --git a/.github/workflows/release-tip.yml b/.github/workflows/release-tip.yml index 81870ecee..2a1eea4b0 100644 --- a/.github/workflows/release-tip.yml +++ b/.github/workflows/release-tip.yml @@ -11,7 +11,7 @@ name: Release Tip jobs: tag: runs-on: ubuntu-latest - needs: [flatpak, build-macos] + needs: [build-macos] steps: - uses: actions/checkout@v4 - name: Tip Tag @@ -21,52 +21,6 @@ jobs: git tag -fa tip -m "Latest Continuous Release" ${GITHUB_SHA} git push --force origin tip - flatpak: - if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }} - runs-on: ubuntu-latest - timeout-minutes: 60 - container: - image: bilelmoussaoui/flatpak-github-actions:gnome-43 - options: --privileged - strategy: - fail-fast: false - matrix: - arch: [x86_64, aarch64] - steps: - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - # Docker is required by the docker/setup-qemu-action which enables emulation - - name: Install deps - run: | - dnf -y install docker - - name: Set up QEMU - id: qemu - uses: docker/setup-qemu-action@v3 - with: - platforms: arm64 - - - uses: flatpak/flatpak-github-actions/flatpak-builder@v6 - with: - bundle: ghostty.flatpak - manifest-path: com.mitchellh.ghostty.yml - branch: tip - cache-key: flatpak-builder-${{ matrix.arch }}-${{ github.sha }}-v1 - arch: ${{ matrix.arch }} - - - name: Rename Bundle - run: mv ghostty.flatpak ghostty-${{ matrix.arch }}.flatpak - - name: Release - uses: softprops/action-gh-release@v1 - with: - name: "Ghostty Tip (\"Nightly\")" - prerelease: true - tag_name: tip - target_commitish: ${{ github.sha }} - files: ghostty-${{ matrix.arch }}.flatpak - token: ${{ secrets.GH_RELEASE_TOKEN }} - build-macos: if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }} runs-on: macos-12 diff --git a/README.md b/README.md index e8f9e3005..1a90c86b7 100644 --- a/README.md +++ b/README.md @@ -47,8 +47,7 @@ things, but I've been using it full time since April 2022. | Platform / Package | Links | Notes | | ----------| ----- | ----- | | macOS | [Tip ("Nightly")](https://github.com/mitchellh/ghostty/releases/tag/tip) | MacOS 12+ Universal Binary | -| Linux (Flatpak) | [Tip ("Nightly")](https://github.com/mitchellh/ghostty/releases/tag/tip) | | -| Linux (Other) | [Build from Source](#developing-ghostty) | | +| Linux | [Build from Source](#developing-ghostty) | | | Windows | n/a | Not supported yet | ### Configuration diff --git a/com.mitchellh.ghostty.yml b/com.mitchellh.ghostty.yml index 19cff44aa..f92f4e99e 100644 --- a/com.mitchellh.ghostty.yml +++ b/com.mitchellh.ghostty.yml @@ -1,3 +1,6 @@ +# Note: the flatpak build is likely broken right now and is not actively +# maintained. We may completely remove this file in the future. For now, +# we want to keep _trying_ but its something with known issues. app-id: com.mitchellh.ghostty runtime: org.gnome.Platform runtime-version: '43' diff --git a/dist/linux/app-flatpak.desktop b/dist/linux/app-flatpak.desktop deleted file mode 100644 index a3748b568..000000000 --- a/dist/linux/app-flatpak.desktop +++ /dev/null @@ -1,14 +0,0 @@ -[Desktop Entry] -Name=Ghostty -Type=Application -Comment=A terminal emulator -Exec=/app/bin/ghostty -Icon=com.mitchellh.ghostty -Keywords=terminal;tty;pty; -StartupNotify=true -Terminal=false -Actions=new-window - -[Desktop Action new-window] -Actions=new-window -Exec=/app/bin/ghostty