Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 16:26:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: deleteLines has to reset wrap state on blank lines

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-10-24 12:50:06 -07:00
parent 66d97ab5f3
commit aee05d9e99
1 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/terminal/Terminal.zig
View File

@ -1832,6 +1832,7 @@ pub fn deleteLines(self: *Terminal, count: usize) !void {
// Insert blank lines // Insert blank lines
for (scroll_end_y..self.scrolling_region.bottom + 1) |y| { for (scroll_end_y..self.scrolling_region.bottom + 1) |y| {
const row = self.screen.getRow(.{ .active = y }); const row = self.screen.getRow(.{ .active = y });
row.setWrapped(false);
row.fillSlice(.{ row.fillSlice(.{
.bg = self.screen.cursor.pen.bg, .bg = self.screen.cursor.pen.bg,
.attrs = .{ .has_bg = self.screen.cursor.pen.attrs.has_bg }, .attrs = .{ .has_bg = self.screen.cursor.pen.attrs.has_bg },
@ -3334,6 +3335,25 @@ test "Terminal: deleteLines left/right scroll region" {
} }
} }
test "Terminal: deleteLines left/right scroll region clears row wrap" {
const alloc = testing.allocator;
var t = try init(alloc, 5, 5);
defer t.deinit(alloc);
try t.print('0');
t.modes.set(.enable_left_and_right_margin, true);
t.setLeftAndRightMargin(2, 3);
try t.printRepeat(1000);
for (0..t.rows - 1) |y| {
const row = t.screen.getRow(.{ .active = y });
try testing.expect(row.isWrapped());
}
{
const row = t.screen.getRow(.{ .active = t.rows - 1 });
try testing.expect(!row.isWrapped());
}
}
test "Terminal: deleteLines left/right scroll region from top" { test "Terminal: deleteLines left/right scroll region from top" {
const alloc = testing.allocator; const alloc = testing.allocator;
var t = try init(alloc, 10, 10); var t = try init(alloc, 10, 10);
@ -4856,6 +4876,25 @@ test "Terminal: resize less cols with wide char then print" {
try t.print('😀'); // 0x1F600 try t.print('😀'); // 0x1F600
} }
// https://github.com/mitchellh/ghostty/issues/723
// This was found via fuzzing so its highly specific.
test "Terminal: resize with left and right margin set" {
const alloc = testing.allocator;
const cols = 70;
const rows = 23;
var t = try init(alloc, cols, rows);
defer t.deinit(alloc);
t.modes.set(.enable_left_and_right_margin, true);
try t.print('0');
t.modes.set(.enable_mode_3, true);
try t.resize(alloc, cols, rows);
t.setLeftAndRightMargin(2, 0);
try t.printRepeat(1850);
_ = t.modes.restore(.enable_mode_3);
try t.resize(alloc, cols, rows);
}
test "Terminal: saveCursor" { test "Terminal: saveCursor" {
const alloc = testing.allocator; const alloc = testing.allocator;
var t = try init(alloc, 3, 3); var t = try init(alloc, 3, 3);