macos: fix goto last tab

This commit is contained in:
Mitchell Hashimoto
2024-10-24 19:56:52 -07:00
parent 553687b5e2
commit a651dbf3bf
2 changed files with 7 additions and 6 deletions

View File

@ -514,14 +514,14 @@ class TerminalController: BaseTerminalController {
return return
} }
} else { } else {
// Tabs are 0-indexed here, so we subtract one from the key the user hit. // The configured value is 1-indexed.
finalIndex = Int(tabIndex - 1) guard tabIndex >= 1 else { return }
// If our index is outside our boundary then we use the max
finalIndex = min(Int(tabIndex - 1), tabbedWindows.count - 1)
} }
guard finalIndex >= 0 else { return } guard finalIndex >= 0 else { return }
if finalIndex >= tabbedWindows.count {
finalIndex = tabbedWindows.count - 1
}
let targetWindow = tabbedWindows[finalIndex] let targetWindow = tabbedWindows[finalIndex]
targetWindow.makeKeyAndOrderFront(nil) targetWindow.makeKeyAndOrderFront(nil)
} }

View File

@ -297,7 +297,8 @@ pub const Action = union(enum) {
/// Go to the last tab (the one with the highest index) /// Go to the last tab (the one with the highest index)
last_tab: void, last_tab: void,
/// Go to the tab with the specific number, 1-indexed. /// Go to the tab with the specific number, 1-indexed. If the tab number
/// is higher than the number of tabs, this will go to the last tab.
goto_tab: usize, goto_tab: usize,
/// Toggle the tab overview. /// Toggle the tab overview.