Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 08:16:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure all search results are visible in theme list

Browse Source 
When searching in the theme list (e.g., searching for "Snazzy"), some matching themes might be hidden due to incorrect window position handling.

This fix ensures all matching themes are visible by adjusting the window position logic.
This commit is contained in:
Bryan Lee
2025-01-03 16:23:10 +08:00
parent e2f9eb6a6f
commit 9fa404c390
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/cli/list_themes.zig
View File

@ -11,6 +11,12 @@ const global_state = &@import("../global.zig").state;
const vaxis = @import("vaxis"); const vaxis = @import("vaxis");
const zf = @import("zf"); const zf = @import("zf");
// When the number of filtered themes is less than or equal to this threshold,
// the window position will be reset to 0 to show all results from the top.
// This ensures better visibility for small result sets while maintaining
// scroll position for larger lists.
const SMALL_LIST_THRESHOLD = 10;
pub const Options = struct { pub const Options = struct {
/// If true, print the full path to the theme. /// If true, print the full path to the theme.
path: bool = false, path: bool = false,
@ -323,9 +329,15 @@ const Preview = struct {
} }
self.current, self.window = current: { self.current, self.window = current: {
if (selected.len == 0) break :current .{ 0, 0 };
for (self.filtered.items, 0..) |index, i| { for (self.filtered.items, 0..) |index, i| {
if (std.mem.eql(u8, self.themes[index].theme, selected)) if (std.mem.eql(u8, self.themes[index].theme, selected)) {
break :current .{ i, i -| relative }; // Keep the relative position but ensure all search results are visible
const new_window = i -| relative;
// If the new window would hide some results at the top, adjust it
break :current .{ i, if (self.filtered.items.len <= SMALL_LIST_THRESHOLD) 0 else new_window };
}
} }
break :current .{ 0, 0 }; break :current .{ 0, 0 };
}; };