Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-20 10:46:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

cli: fix integer overflow in +list-themes if window is too narrow

Browse Source 
Reproduction is to resize the window to it's minimum width and then
run `ghostty +list-themes`. Ghostty will crash because Zig for loops
don't like having a range where the end is smaller than the start.
This commit is contained in:
Jeffrey C. Ollie
2024-09-28 12:12:00 -05:00
parent 870a1dae3d
commit 9f543ceac2
1 changed files with 42 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
src/cli/list_themes.zig
View File

@ -1068,19 +1068,21 @@ const Preview = struct {
.col_offset = 2, .col_offset = 2,
}, },
); );
for (10..child.width) |col| { if (child.width > 10) {
_ = try child.print( for (10..child.width) |col| {
&.{ _ = try child.print(
.{ &.{
.text = "─", .{
.style = color238, .text = "─",
.style = color238,
},
}, },
}, .{
.{ .row_offset = 1,
.row_offset = 1, .col_offset = col,
.col_offset = col, },
}, );
); }
} }
} }
_ = try child.print( _ = try child.print(
@ -1118,19 +1120,21 @@ const Preview = struct {
.col_offset = 2, .col_offset = 2,
}, },
); );
for (10..child.width) |col| { if (child.width > 10) {
_ = try child.print( for (10..child.width) |col| {
&.{ _ = try child.print(
.{ &.{
.text = "─", .{
.style = color238, .text = "─",
.style = color238,
},
}, },
}, .{
.{ .row_offset = 3,
.row_offset = 3, .col_offset = col,
.col_offset = col, },
}, );
); }
} }
} }
_ = try child.print( _ = try child.print(
@ -1383,19 +1387,21 @@ const Preview = struct {
.col_offset = 2, .col_offset = 2,
}, },
); );
for (10..child.width) |col| { if (child.width > 10) {
_ = try child.print( for (10..child.width) |col| {
&.{ _ = try child.print(
.{ &.{
.text = "─", .{
.style = color238, .text = "─",
.style = color238,
},
}, },
}, .{
.{ .row_offset = 21,
.row_offset = 21, .col_offset = col,
.col_offset = col, },
}, );
); }
} }
} }
_ = try child.print( _ = try child.print(