Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

code review

Browse Source 
- Change show_message_box from struct to string.
- Add tests:
  - Blank message
  - Spaces only message
  - No trailing semicolon OSC 9;2
This commit is contained in:
Damien Mehala
2025-01-03 11:57:31 +01:00
parent 8d7ed3e0fc
commit 8a3aae2caf
1 changed files with 44 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
src/terminal/osc.zig
View File

@ -159,9 +159,7 @@ pub const Command = union(enum) {
hyperlink_end: void,
/// Show GUI message Box (OSC 9;2)
show_message_box: struct {
content: []const u8,
},
show_message_box: []const u8,
/// Set progress state (OSC 9;4)
progress: struct {
@ -799,9 +797,10 @@ pub const Parser = struct {
.conemu_message_box => switch (c) {
';' => {
self.command = .{ .show_message_box = .{ .content = undefined } };
self.temp_state = .{ .str = &self.command.show_message_box.content };
self.command = .{ .show_message_box = undefined };
self.temp_state = .{ .str = &self.command.show_message_box };
self.buf_start = self.buf_idx;
self.complete = true;
self.prepAllocableString();
},
else => self.state = .invalid,
@ -1681,7 +1680,7 @@ test "OSC: show desktop notification with title" {
try testing.expectEqualStrings(cmd.show_desktop_notification.body, "Body");
}
test "OSC: OSC9;2 conemu message box" {
test "OSC: conemu message box" {
const testing = std.testing;
var p: Parser = .{};
@ -1691,7 +1690,45 @@ test "OSC: OSC9;2 conemu message box" {
const cmd = p.end('\x1b').?;
try testing.expect(cmd == .show_message_box);
try testing.expectEqualStrings("hello world", cmd.show_message_box.content);
try testing.expectEqualStrings("hello world", cmd.show_message_box);
}
test "OSC: conemu message box invalid input" {
const testing = std.testing;
var p: Parser = .{};
const input = "9;2";
for (input) |ch| p.next(ch);
const cmd = p.end('\x1b');
try testing.expect(cmd == null);
}
test "OSC: conemu message box empty message" {
const testing = std.testing;
var p: Parser = .{};
const input = "9;2;";
for (input) |ch| p.next(ch);
const cmd = p.end('\x1b').?;
try testing.expect(cmd == .show_message_box);
try testing.expectEqualStrings("", cmd.show_message_box);
}
test "OSC: conemu message box spaces only message" {
const testing = std.testing;
var p: Parser = .{};
const input = "9;2; ";
for (input) |ch| p.next(ch);
const cmd = p.end('\x1b').?;
try testing.expect(cmd == .show_message_box);
try testing.expectEqualStrings(" ", cmd.show_message_box);
}
test "OSC: OSC9 progress set" {