From 872c1211f5d4742c7b63e5815ff60238cdcf3554 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Sat, 18 Mar 2023 19:15:29 -0700 Subject: [PATCH] pty: deinit should close child end --- src/Pty.zig | 1 + src/termio/Exec.zig | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Pty.zig b/src/Pty.zig index f9d419ec0..09a3f9a1a 100644 --- a/src/Pty.zig +++ b/src/Pty.zig @@ -80,6 +80,7 @@ pub fn open(size: winsize) !Pty { pub fn deinit(self: *Pty) void { _ = std.os.system.close(self.master); + _ = std.os.system.close(self.slave); self.* = undefined; } diff --git a/src/termio/Exec.zig b/src/termio/Exec.zig index 10d48b8eb..9a2fc7459 100644 --- a/src/termio/Exec.zig +++ b/src/termio/Exec.zig @@ -185,9 +185,6 @@ pub fn threadExit(self: *Exec, data: ThreadData) void { if (data.ev.process_exited) self.subprocess.externalExit(); self.subprocess.stop(); - // Wait for our subprocess to report it exited. - // data.ev.loop.run(.once); - // Wait for our reader thread to end data.read_thread.join(); }