Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 00:36:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: insertLines with count 0 no longer crashes

Browse Source
This commit is contained in:
Mitchell Hashimoto
2022-12-14 21:29:06 -08:00
parent 0592e4fa1a
commit 8534e5a186
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/terminal/Terminal.zig
View File

@ -1226,6 +1226,9 @@ pub fn insertLines(self: *Terminal, count: usize) !void {
const tracy = trace(@src()); const tracy = trace(@src());
defer tracy.end(); defer tracy.end();
// Rare, but happens
if (count == 0) return;
// Move the cursor to the left margin // Move the cursor to the left margin
self.screen.cursor.x = 0; self.screen.cursor.x = 0;
@ -1790,6 +1793,16 @@ test "Terminal: insertLines" {
} }
} }
test "Terminal: insertLines zero" {
const alloc = testing.allocator;
var t = try init(alloc, 2, 5);
defer t.deinit(alloc);
// This should do nothing
t.setCursorPos(1, 1);
try t.insertLines(0);
}
test "Terminal: insertLines with scroll region" { test "Terminal: insertLines with scroll region" {
const alloc = testing.allocator; const alloc = testing.allocator;
var t = try init(alloc, 2, 6); var t = try init(alloc, 2, 6);