Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-25 13:16:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

command: fix hostname test compatibility (#2924)

Browse Source 
`hostname` is not guaranteed on *nix as in the comment. For example,
Arch does not have hostname by default.

`uname -n` is supposed to be the POSIX way to get the hostname, so I
replaced `hostname` with `uname`.

(I assumed that it is not that important to have a same name binary on
platforms, since we have to add `.exe` on Windows anyway)

(And also, I did agree to the MIT relicensing, but I changed my email
since then, so I will agree to the relicensing again here)
This commit is contained in:
Mitchell Hashimoto
2024-12-11 08:57:44 -08:00
committed by GitHub
parent 63f77f0c9f cb5848c7b7
commit 83545d9be5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Command.zig
View File

@ -440,9 +440,9 @@ fn isExecutable(mode: std.fs.File.Mode) bool {
return mode & 0o0111 != 0;
}
// `hostname` is present on both *nix and windows
// `uname -n` is the *nix equivalent of `hostname.exe` on Windows
test "expandPath: hostname" {
const executable = if (builtin.os.tag == .windows) "hostname.exe" else "hostname";
const executable = if (builtin.os.tag == .windows) "hostname.exe" else "uname";
const path = (try expandPath(testing.allocator, executable)).?;
defer testing.allocator.free(path);
try testing.expect(path.len > executable.len);