Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 08:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

apprt/embedded: fix char callback ignore when key is consumed

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-08-10 22:03:20 -07:00
parent 4fe739cae0
commit 7ea8feea69
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/apprt/embedded.zig
View File

@ -441,6 +441,15 @@ pub const Surface = struct {
// If we consume the key then we want to reset the dead key state. // If we consume the key then we want to reset the dead key state.
if (consumed) { if (consumed) {
self.keymap_state = .{}; self.keymap_state = .{};
// This is kloodge right now to reset the surface ignore_char
// state. We should refactor the API contract with the surface
// to be that if we consume a key then we don't call the char
// callback.
//
// If you don't do this, then after a consumed char a pure
// char event will be ignored. i.e. an emoji keyboard entry.
self.core_surface.charCallback(0) catch {};
return; return;
} }
} }
@ -452,7 +461,6 @@ pub const Surface = struct {
// we can show the user that we're in dead key mode and the // we can show the user that we're in dead key mode and the
// precomposed character. For now, we can just ignore and that // precomposed character. For now, we can just ignore and that
// is not incorrect behavior. // is not incorrect behavior.
log.warn("dead key mode, currently composing", .{});
return; return;
} }