From a874280e4b0943ce708fc4b72f3ae4235d8c429a Mon Sep 17 00:00:00 2001 From: Troels Thomsen Date: Thu, 15 Feb 2024 22:53:44 +0100 Subject: [PATCH 1/2] Avoid repainting new tab button for native tab bar --- macos/Sources/Features/Terminal/TerminalWindow.swift | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/macos/Sources/Features/Terminal/TerminalWindow.swift b/macos/Sources/Features/Terminal/TerminalWindow.swift index 44864d511..5fa06cfb0 100644 --- a/macos/Sources/Features/Terminal/TerminalWindow.swift +++ b/macos/Sources/Features/Terminal/TerminalWindow.swift @@ -16,12 +16,18 @@ class TerminalWindow: NSWindow { } super.becomeKey() - updateNewTabButtonOpacity() + + if titlebarTabs { + updateNewTabButtonOpacity() + } } override func resignKey() { super.resignKey() - updateNewTabButtonOpacity() + + if titlebarTabs { + updateNewTabButtonOpacity() + } } // MARK: - Titlebar Tabs @@ -211,6 +217,8 @@ class TerminalWindow: NSWindow { override func update() { super.update() + guard titlebarTabs else { return } + // This is called when we open, close, switch, and reorder tabs, at which point we determine if the // first tab in the tab bar is selected. If it is, we make the `windowButtonsBackdrop` color the same // as that of the active tab (i.e. the titlebar's background color), otherwise we make it the same From f7a9879579fb29fbcbfaa9326cc2df725cbdd69c Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Fri, 16 Feb 2024 13:59:42 -0800 Subject: [PATCH 2/2] build: fix issue for long branch names --- src/build_config.zig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/build_config.zig b/src/build_config.zig index 33b76d252..803e3ee4d 100644 --- a/src/build_config.zig +++ b/src/build_config.zig @@ -50,8 +50,9 @@ pub const BuildConfig = struct { step.addOption(bool, "wasm_shared", self.wasm_shared); // Our version. We also add the string version so we don't need - // to do any allocations at runtime. - var buf: [64]u8 = undefined; + // to do any allocations at runtime. This has to be long enough to + // accomodate realistic large branch names for dev versions. + var buf: [1024]u8 = undefined; step.addOption(std.SemanticVersion, "app_version", self.version); step.addOption([:0]const u8, "app_version_string", try std.fmt.bufPrintZ( &buf,