Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-22 19:56:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

renderer: skip virtual placements

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-07-24 11:52:49 -07:00
parent 7d9e50353b
commit 763e7fab8a
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/renderer/Metal.zig
View File

@ -1598,8 +1598,11 @@ fn prepKittyGraphics(
continue; continue;
}; };
// Get the rect for the placement. If this placement doesn't have
// a rect then its virtual or something so skip it.
const rect = p.rect(image, t) orelse continue;
// If the selection isn't within our viewport then skip it. // If the selection isn't within our viewport then skip it.
const rect = p.rect(image, t);
if (bot.before(rect.top_left)) continue; if (bot.before(rect.top_left)) continue;
if (rect.bottom_right.before(top)) continue; if (rect.bottom_right.before(top)) continue;
@ -1656,7 +1659,7 @@ fn prepKittyGraphics(
// Convert our screen point to a viewport point // Convert our screen point to a viewport point
const viewport: terminal.point.Point = t.screen.pages.pointFromPin( const viewport: terminal.point.Point = t.screen.pages.pointFromPin(
.viewport, .viewport,
p.pin.*, rect.top_left,
) orelse .{ .viewport = .{} }; ) orelse .{ .viewport = .{} };
// Calculate the source rectangle // Calculate the source rectangle
@ -1679,7 +1682,7 @@ fn prepKittyGraphics(
if (image.width > 0 and image.height > 0) { if (image.width > 0 and image.height > 0) {
try self.image_placements.append(self.alloc, .{ try self.image_placements.append(self.alloc, .{
.image_id = kv.key_ptr.image_id, .image_id = kv.key_ptr.image_id,
.x = @intCast(p.pin.x), .x = @intCast(rect.top_left.x),
.y = @intCast(viewport.viewport.y), .y = @intCast(viewport.viewport.y),
.z = p.z, .z = p.z,
.width = dest_width, .width = dest_width,

9
src/renderer/OpenGL.zig
View File

@ -785,8 +785,11 @@ fn prepKittyGraphics(
continue; continue;
}; };
// Get the rect for the placement. If this placement doesn't have
// a rect then its virtual or something so skip it.
const rect = p.rect(image, t) orelse continue;
// If the selection isn't within our viewport then skip it. // If the selection isn't within our viewport then skip it.
const rect = p.rect(image, t);
if (bot.before(rect.top_left)) continue; if (bot.before(rect.top_left)) continue;
if (rect.bottom_right.before(top)) continue; if (rect.bottom_right.before(top)) continue;
@ -843,7 +846,7 @@ fn prepKittyGraphics(
// Convert our screen point to a viewport point // Convert our screen point to a viewport point
const viewport: terminal.point.Point = t.screen.pages.pointFromPin( const viewport: terminal.point.Point = t.screen.pages.pointFromPin(
.viewport, .viewport,
p.pin.*, rect.top_left,
) orelse .{ .viewport = .{} }; ) orelse .{ .viewport = .{} };
// Calculate the source rectangle // Calculate the source rectangle
@ -866,7 +869,7 @@ fn prepKittyGraphics(
if (image.width > 0 and image.height > 0) { if (image.width > 0 and image.height > 0) {
try self.image_placements.append(self.alloc, .{ try self.image_placements.append(self.alloc, .{
.image_id = kv.key_ptr.image_id, .image_id = kv.key_ptr.image_id,
.x = @intCast(p.pin.x), .x = @intCast(rect.top_left.x),
.y = @intCast(viewport.viewport.y), .y = @intCast(viewport.viewport.y),
.z = p.z, .z = p.z,
.width = dest_width, .width = dest_width,