Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 00:06:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory corruption in Screen.cursorScrollAboveRotate

Browse Source 
Unless it's guaranteed that the new pin is in the same page as the old
one, `cursor.page_pin` should only be updated through `cursorChangePin`,
not directly.
This commit is contained in:
Qwerasd
2024-12-24 22:47:38 -05:00
parent a387e680ed
commit 6d034d04a0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/terminal/Screen.zig
View File

@ -863,7 +863,7 @@ pub fn cursorScrollAbove(self: *Screen) !void {
} }
fn cursorScrollAboveRotate(self: *Screen) !void { fn cursorScrollAboveRotate(self: *Screen) !void {
self.cursor.page_pin.* = self.cursor.page_pin.down(1).?; self.cursorChangePin(self.cursor.page_pin.down(1).?);
// Go through each of the pages following our pin, shift all rows // Go through each of the pages following our pin, shift all rows
// down by one, and copy the last row of the previous page. // down by one, and copy the last row of the previous page.