Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

macos: prevent mouseEntered/Exited processing if already in that state

Browse Source 
See the comment in the code.

Fixes #494
This commit is contained in:
Mitchell Hashimoto
2023-09-20 08:53:31 -07:00
parent ca20bda3e9
commit 6cee9e57f6
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
macos/Sources/Ghostty/SurfaceView.swift
View File

@ -491,6 +491,12 @@ extension Ghostty {
} }
override func mouseEntered(with event: NSEvent) { override func mouseEntered(with event: NSEvent) {
// For reasons unknown (Cocoaaaaaaaaa), mouseEntered is called
// multiple times in an unbalanced way with mouseExited when a new
// tab is created. In this scenario, we only want to process our
// callback once since this is stateful and we expect balancing.
if (mouseEntered) { return }
mouseEntered = true mouseEntered = true
// If our cursor is hidden, we hide it on upon entry and we unhide // If our cursor is hidden, we hide it on upon entry and we unhide
@ -501,6 +507,9 @@ extension Ghostty {
} }
override func mouseExited(with event: NSEvent) { override func mouseExited(with event: NSEvent) {
// See mouseEntered
if (!mouseEntered) { return }
mouseEntered = false mouseEntered = false
if (cursorVisible == .hidden) { if (cursorVisible == .hidden) {