From 6a8dc12ae146cf2d6890d7378bf60c6191a21e10 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Tue, 28 May 2024 20:54:05 -0700 Subject: [PATCH] font: remove deferred face todo, note why --- src/font/DeferredFace.zig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/font/DeferredFace.zig b/src/font/DeferredFace.zig index 94fbab445..fc7c81378 100644 --- a/src/font/DeferredFace.zig +++ b/src/font/DeferredFace.zig @@ -281,7 +281,12 @@ pub fn hasCodepoint(self: DeferredFace, cp: u32, p: ?Presentation) bool { => { // If we are using coretext, we check the loaded CT font. if (self.ct) |ct| { - // TODO(mixed-fonts): handle presentation on a glyph level + // This presentation check isn't as detailed as isColorGlyph + // because forced presentation modes are only used for emoji and + // emoji should always have color glyphs set. This can be + // more correct by using the isColorGlyph logic but I'd want + // to find a font that actualy requires this so we can write + // a test for it before changing it. if (p) |desired_p| { const traits = ct.font.getSymbolicTraits(); const actual_p: Presentation = if (traits.color_glyphs) .emoji else .text;