Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 07:46:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(Metal): handle non-extended padding color transparency (#5126)

Browse Source 
We were returning bg colors when we shouldn't have since when we have
background color transparency we need to return any bg color cells as
fully transparent rather than their actual color.

This caused a problem of overly opaque padding when background opacity
was < 1.0
This commit is contained in:
Mitchell Hashimoto
2025-01-16 12:58:46 -08:00
committed by GitHub
parent ff9414d9ea b1becb12c0
commit 62d3786c66
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/renderer/shaders/cell.metal
View File

@ -248,7 +248,15 @@ fragment float4 cell_bg_fragment(
) {
int2 grid_pos = int2(floor((in.position.xy - uniforms.grid_padding.wx) / uniforms.cell_size));
float4 bg = in.bg_color;
float4 bg = float4(0.0);
// If we have any background transparency then we render bg-colored cells as
// fully transparent, since the background is handled by the layer bg color
// and we don't want to double up our bg color, but if our bg color is fully
// opaque then our layer is opaque and can't handle transparency, so we need
// to return the bg color directly instead.
if (uniforms.bg_color.a == 255) {
bg = in.bg_color;
}
// Clamp x position, extends edge bg colors in to padding on sides.
if (grid_pos.x < 0) {
@ -285,16 +293,7 @@ fragment float4 cell_bg_fragment(
// We have special case handling for when the cell color matches the bg color.
if (all(cell_color == uniforms.bg_color)) {
// If we have any background transparency then we render bg-colored cells as
// fully transparent, since the background is handled by the layer bg color
// and we don't want to double up our bg color, but if our bg color is fully
// opaque then our layer is opaque and can't handle transparency, so we need
// to return the bg color directly instead.
if (uniforms.bg_color.a == 255) {
return bg;
} else {
return float4(0.0);
}
return bg;
}
// Convert the color and return it.