Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: ICH should only run with no intermediates

Browse Source
This commit is contained in:
Mitchell Hashimoto
2023-10-24 09:41:20 -07:00
parent ec26cc4b41
commit 62475fd709
1 changed files with 32 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/terminal/stream.zig
View File

@ -926,12 +926,18 @@ pub fn Stream(comptime Handler: type) type {
},
// ICH - Insert Blanks
// TODO: test
'@' => if (@hasDecl(T, "insertBlanks")) switch (action.params.len) {
0 => try self.handler.insertBlanks(1),
1 => try self.handler.insertBlanks(action.params[0]),
else => log.warn("invalid ICH command: {}", .{action}),
} else log.warn("unimplemented CSI callback: {}", .{action}),
'@' => switch (action.intermediates.len) {
0 => if (@hasDecl(T, "insertBlanks")) switch (action.params.len) {
0 => try self.handler.insertBlanks(1),
1 => try self.handler.insertBlanks(action.params[0]),
else => log.warn("invalid ICH command: {}", .{action}),
} else log.warn("unimplemented CSI callback: {}", .{action}),
else => log.warn(
"ignoring unimplemented CSI @: {}",
.{action},
),
},
// DECSASD - Select Active Status Display
'}' => {
@ -1572,3 +1578,23 @@ test "stream: XTSHIFTESCAPE" {
try s.nextSlice("\x1B[>1s");
try testing.expect(s.handler.escape.? == true);
}
test "stream: insert characters" {
const H = struct {
const Self = @This();
called: bool = false,
pub fn insertBlanks(self: *Self, v: u16) !void {
_ = v;
self.called = true;
}
};
var s: Stream(H) = .{ .handler = .{} };
for ("\x1B[42@") |c| try s.next(c);
try testing.expect(s.handler.called);
s.handler.called = false;
for ("\x1B[?42@") |c| try s.next(c);
try testing.expect(!s.handler.called);
}