Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

avoid asserting working directory is absolute (#3028)

Browse Source 
`std.fs.accessAbsolute` asserts if the user proposed path is absolute,
which we are seemingly passing as-is with no validating that it is.

When running with safety checks on, passing non-absolute path to
--working-directory will make ghostty crash.

I changed it to use `Dir.access`, which is just `accessAbsolute` without
the check.

This has the side effect of also allowing relative working directory.
This commit is contained in:
Mitchell Hashimoto
2024-12-20 08:25:51 -08:00
committed by GitHub
parent 0f588d72c7 239056c90f
commit 5bb05996eb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/termio/Exec.zig
View File

@ -1135,7 +1135,7 @@ const Subprocess = struct {
// This is important because our cwd can be set by the shell (OSC 7) // This is important because our cwd can be set by the shell (OSC 7)
// and we don't want to break new windows. // and we don't want to break new windows.
const cwd: ?[]const u8 = if (self.cwd) |proposed| cwd: { const cwd: ?[]const u8 = if (self.cwd) |proposed| cwd: {
if (std.fs.accessAbsolute(proposed, .{})) { if (std.fs.cwd().access(proposed, .{})) {
break :cwd proposed; break :cwd proposed;
} else |err| { } else |err| {
log.warn("cannot access cwd, ignoring: {}", .{err}); log.warn("cannot access cwd, ignoring: {}", .{err});