From a4913811913a11af85924c0ef780d3fe910c01d6 Mon Sep 17 00:00:00 2001 From: RGBCube Date: Fri, 29 Mar 2024 22:24:32 +0300 Subject: [PATCH 1/2] nix: make ReleaseFast the default package --- flake.nix | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/flake.nix b/flake.nix index ad7d4da17..347cd1de8 100644 --- a/flake.nix +++ b/flake.nix @@ -52,23 +52,19 @@ wraptest = pkgs-stable.callPackage ./nix/wraptest.nix {}; }; - packages.${system} = rec { - ghostty-debug = pkgs-stable.callPackage ./nix/package.nix { + packages.${system} = let + mkArgs = optimize: { inherit (pkgs-zig-0-12) zig_0_12; + inherit optimize; + revision = self.shortRev or self.dirtyShortRev or "dirty"; - optimize = "Debug"; }; - ghostty-releasesafe = pkgs-stable.callPackage ./nix/package.nix { - inherit (pkgs-zig-0-12) zig_0_12; - revision = self.shortRev or self.dirtyShortRev or "dirty"; - optimize = "ReleaseSafe"; - }; - ghostty-releasefast = pkgs-stable.callPackage ./nix/package.nix { - inherit (pkgs-zig-0-12) zig_0_12; - revision = self.shortRev or self.dirtyShortRev or "dirty"; - optimize = "ReleaseFast"; - }; - ghostty = ghostty-releasesafe; + in rec { + ghostty-debug = pkgs-stable.callPackage ./nix/package.nix (mkArgs "Debug"); + ghostty-releasesafe = pkgs-stable.callPackage ./nix/package.nix (mkArgs "ReleaseSafe"); + ghostty-releasefast = pkgs-stable.callPackage ./nix/package.nix (mkArgs "ReleaseFast"); + + ghostty = ghostty-releasefast; default = ghostty; }; From aa928b8d874d96e089f8ee7728cf387d9cf8da00 Mon Sep 17 00:00:00 2001 From: RGBCube Date: Fri, 29 Mar 2024 22:27:32 +0300 Subject: [PATCH 2/2] nix: use packages = instead of (native)buildInputs as that is recommended --- nix/devShell.nix | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/nix/devShell.nix b/nix/devShell.nix index c5bd045d5..e36a2f873 100644 --- a/nix/devShell.nix +++ b/nix/devShell.nix @@ -78,7 +78,7 @@ in mkShell { name = "ghostty"; - nativeBuildInputs = + packages = [ # For builds llvmPackages_latest.llvm @@ -120,13 +120,7 @@ in gdb valgrind wraptest - ]; - buildInputs = - [ - # TODO: non-linux - ] - ++ lib.optionals stdenv.isLinux [ bzip2 expat fontconfig