Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 00:06:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

perf(RefCountedSet): make swap metric prioritize high refcount items

Browse Source 
This experimentally yields a ~20% performance improvement as measured by
running DOOM-fire-zig, which is honestly a lot more than I expected.
This commit is contained in:
Qwerasd
2024-12-23 21:41:51 -05:00
parent 42cdaa4545
commit 56cbbd940b
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/terminal/ref_counted_set.zig
View File

@ -607,8 +607,16 @@ pub fn RefCountedSet(
break; break;
} }
// This item has a lower PSL, swap it out with our held item. // If this item has a lower PSL, or has equal PSL and lower ref
if (item.meta.psl < held_item.meta.psl) { // count, then we swap it out with our held item. By doing this,
// items with high reference counts are prioritized for earlier
// placement. The assumption is that an item which has a higher
// reference count will be accessed more frequently, so we want
// to minimize the time it takes to find it.
if (item.meta.psl < held_item.meta.psl or
item.meta.psl == held_item.meta.psl and
item.meta.ref < held_item.meta.ref)
{
// Put our held item in the bucket. // Put our held item in the bucket.
table[p] = held_id; table[p] = held_id;
held_item.meta.bucket = p; held_item.meta.bucket = p;