Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1084 from mitchellh/kitty-again

Browse Source 
input/kitty: do not encode event with mods if press
This commit is contained in:
Mitchell Hashimoto
2023-12-13 13:41:46 -08:00
committed by GitHub
parent 8dba9f0cd6 5a372f6a06
commit 54a5246ead
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/input/KeyEncoder.zig
View File

@ -710,20 +710,12 @@ const KittySequence = struct {
// Mods and events section // Mods and events section
const mods = self.mods.seqInt(); const mods = self.mods.seqInt();
var emit_prior = false; var emit_prior = false;
if (self.event != .none) { if (self.event != .none and self.event != .press) {
// Easier to understand if you De Morgan this: we skip try writer.print(
// if we have no mods AND its a press event. In that case ";{d}:{d}",
// both are "1" and empty also means default. In theory .{ mods, @intFromEnum(self.event) },
// there is no harm being explicit here but Kitty doesn't );
// output in this case and we want to match here. This is emit_prior = true;
// unit tested.
if (self.event != .press or mods > 1) {
try writer.print(
";{d}:{d}",
.{ mods, @intFromEnum(self.event) },
);
emit_prior = true;
}
} else if (mods > 1) { } else if (mods > 1) {
try writer.print(";{d}", .{mods}); try writer.print(";{d}", .{mods});
emit_prior = true; emit_prior = true;
@ -974,6 +966,22 @@ test "kitty: enter with all flags" {
try testing.expectEqualStrings("[13u", actual[1..]); try testing.expectEqualStrings("[13u", actual[1..]);
} }
test "kitty: ctrl with all flags" {
var buf: [128]u8 = undefined;
var enc: KeyEncoder = .{
.event = .{ .key = .left_control, .mods = .{ .ctrl = true }, .utf8 = "" },
.kitty_flags = .{
.disambiguate = true,
.report_events = true,
.report_alternates = true,
.report_all = true,
.report_associated = true,
},
};
const actual = try enc.kitty(&buf);
try testing.expectEqualStrings("[57442;5u", actual[1..]);
}
test "kitty: delete" { test "kitty: delete" {
var buf: [128]u8 = undefined; var buf: [128]u8 = undefined;
{ {