mirror of
https://github.com/ghostty-org/ghostty.git
synced 2025-07-15 00:06:09 +03:00
fix(kittygfx): load & display command shouldn't respond to i=0,I=0
Load and display (`T`) was responding even with implicit IDs, because the display was achieved with an early return in the transmit function that bypassed the logic to silence implicit ID responses- by making it not an early return we fix this.
This commit is contained in:
@ -155,7 +155,7 @@ fn transmit(
|
|||||||
assert(!load.more);
|
assert(!load.more);
|
||||||
var d_copy = d;
|
var d_copy = d;
|
||||||
d_copy.image_id = load.image.id;
|
d_copy.image_id = load.image.id;
|
||||||
return display(alloc, terminal, &.{
|
result = display(alloc, terminal, &.{
|
||||||
.control = .{ .display = d_copy },
|
.control = .{ .display = d_copy },
|
||||||
.quiet = cmd.quiet,
|
.quiet = cmd.quiet,
|
||||||
});
|
});
|
||||||
@ -551,3 +551,21 @@ test "kittygfx no response with no image ID or number" {
|
|||||||
try testing.expect(resp == null);
|
try testing.expect(resp == null);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
test "kittygfx no response with no image ID or number load and display" {
|
||||||
|
const testing = std.testing;
|
||||||
|
const alloc = testing.allocator;
|
||||||
|
|
||||||
|
var t = try Terminal.init(alloc, .{ .rows = 5, .cols = 5 });
|
||||||
|
defer t.deinit(alloc);
|
||||||
|
|
||||||
|
{
|
||||||
|
const cmd = try command.Parser.parseString(
|
||||||
|
alloc,
|
||||||
|
"a=T,f=24,t=d,s=1,v=2,c=10,r=1,i=0,I=0;////////",
|
||||||
|
);
|
||||||
|
defer cmd.deinit(alloc);
|
||||||
|
const resp = execute(alloc, &t, &cmd);
|
||||||
|
try testing.expect(resp == null);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Reference in New Issue
Block a user