Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-23 12:16:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

linux/systemd: add an app- prefix to the systemd unit (#7959)

Browse Source 
The XDG Freedesktop Portal has a _major_ undocumented requirement for
programs that are launched/controlled by `systemd` to interact with the
Portal. The unit _must_ be named `app-<appid>.service`. The Portal uses
the systemd unit name figure out what the program's application ID is
and it will only look at unit names that begin with `app-`. I can find
no place that this is documented other than by inspecting the code or
the
issue and PR that introduced this feature. See the following code:


7d4d48cf07/src/xdp-utils.c (L152-L220)

This may fix many people's issues with getting global shortcuts
to work.

Note that this is a breaking change if you have been using Ghostty
compiled from source since
https://github.com/ghostty-org/ghostty/pull/7433 was merged. You will
need to ensure
that any Ghosty systemd unit files _not_ prefixed with `app-` are
deleted.

Original discussion/PR in the XDG Desktop Portal repository:

https://github.com/flatpak/xdg-desktop-portal/issues/579
https://github.com/flatpak/xdg-desktop-portal/pull/719

Originally discussed on Discord:

https://discord.com/channels/1005603569187160125/1394845362186879026

Co-authored-by: ambareeshbalaji@gmail.com
This commit is contained in:
Jeffrey C. Ollie
2025-07-16 11:48:34 -05:00
committed by GitHub
parent f44c24ef88 959b2c8d7f
commit 50a88dcfe7
2 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dist/linux/dbus.service.in vendored
View File

@ -1,4 +1,4 @@
[D-BUS Service] [D-BUS Service]
Name=@APPID@ Name=@APPID@
SystemdService=@APPID@.service SystemdService=app-@APPID@.service
Exec=@GHOSTTY@ --launched-from=dbus Exec=@GHOSTTY@ --launched-from=dbus

26
src/build/GhosttyResources.zig
View File

@ -283,17 +283,27 @@ fn addLinuxAppResources(
b.fmt("share/dbus-1/services/{s}.service", .{app_id}), b.fmt("share/dbus-1/services/{s}.service", .{app_id}),
}); });
// systemd user service. This is kind of nasty but systemd // `systemd` user service. This is kind of nasty but `systemd` looks for
// looks for user services in different paths depending on // user services in different paths depending on if we are installed
// if we are installed as a system package or not (lib vs. // as a system package or not (lib vs. share) so we have to handle that
// share) so we have to handle that here. We might be able // here. We might be able to get away with always installing to both
// to get away with always installing to both because it // because it only ever searches in one... but I don't want to do that
// only ever searches in one... but I don't want to do that hack // hack until we have to.
// until we have to. //
// The XDG Freedesktop Portal has a major undocumented requirement
// for programs that are launched/controlled by `systemd` to interact
// with the Portal. The unit must be named `app-<appid>.service`. The
// Portal uses the `systemd` unit name figure out what the program's
// application ID is and it will only look at unit names that begin with
// `app-`. I can find no place that this is documented other than by
// inspecting the code or the issue and PR that introduced this feature.
// See the following code:
//
// https://github.com/flatpak/xdg-desktop-portal/blob/7d4d48cf079147c8887da17ec6c3954acd5a285c/src/xdp-utils.c#L152-L220
if (!cfg.flatpak) try ts.append(.{ if (!cfg.flatpak) try ts.append(.{
b.path("dist/linux/systemd.service.in"), b.path("dist/linux/systemd.service.in"),
b.fmt( b.fmt(
"{s}/systemd/user/{s}.service", "{s}/systemd/user/app-{s}.service",
.{ .{
if (b.graph.system_package_mode) "lib" else "share", if (b.graph.system_package_mode) "lib" else "share",
app_id, app_id,