Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 00:06:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

add some comments

Browse Source
This commit is contained in:
David Rubin
2024-12-24 10:07:58 -08:00
parent 120a2b9597
commit 5052be3efe
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/terminal/style.zig
View File

@ -239,6 +239,14 @@ pub const Style = struct {
_ = try writer.write(" }"); _ = try writer.write(" }");
} }
/// `PackedStyle` represents the same data as `Style` but without padding,
/// which is necassary for hashing via re-interpretation of the underlying bytes.
///
/// `Style` is still prefered for everything else as it has type-safety when using
/// the `Color` tagged union.
///
/// Empirical testing shows that storing all of the tags first and then the datas
/// provides a better layout for serializing into and is faster on benchmarks.
const PackedStyle = packed struct(u128) { const PackedStyle = packed struct(u128) {
tags: packed struct { tags: packed struct {
fg: Color.Tag, fg: Color.Tag,
@ -253,6 +261,10 @@ pub const Style = struct {
flags: Flags, flags: Flags,
_padding: u16 = 0, _padding: u16 = 0,
/// After https://github.com/ziglang/zig/issues/19754 is implemented, it
/// will be an compiler-error to have packed union fields of differing size.
///
/// For now we just need to be careful not to accidentally introduce padding.
const Data = packed union { const Data = packed union {
none: u24, none: u24,
palette: packed struct(u24) { palette: packed struct(u24) {