Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 07:46:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(Metal): always render explicit background colors fully opaque (#5335)

Browse Source 
This fixes a regression introduced by the rework of this area before
during the color space changes (#4913). It seems like the original
intent of this code was the behavior it regressed to, but it turns out
to be better like this.
This commit is contained in:
Mitchell Hashimoto
2025-01-23 19:16:10 -08:00
committed by GitHub
parent 95327bff18 78790f6ef7
commit 4b82e0aa2b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/renderer/Metal.zig
View File

@ -2672,9 +2672,8 @@ fn rebuildCells(
// Cells that are reversed should be fully opaque. // Cells that are reversed should be fully opaque.
if (style.flags.inverse) break :bg_alpha default; if (style.flags.inverse) break :bg_alpha default;
// Cells that have an explicit bg color, which does not // Cells that have an explicit bg color should be fully opaque.
// match the current surface bg, should be fully opaque. if (bg_style != null) {
if (bg != null and !rgb.eql(self.background_color orelse self.default_background_color)) {
break :bg_alpha default; break :bg_alpha default;
} }