Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 00:36:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

terminal: parse table needs to have room for all chars

Browse Source
This commit is contained in:
Mitchell Hashimoto
2022-12-14 21:10:22 -08:00
parent 36c6e95dfc
commit 4a3e2b35b9
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/terminal/Parser.zig
View File

@ -245,7 +245,10 @@ pub fn next(self: *Parser, c: u8) [3]?Action {
// In debug mode, we log bad state transitions. // In debug mode, we log bad state transitions.
if (builtin.mode == .Debug) { if (builtin.mode == .Debug) {
if (next_state == .anywhere) { if (next_state == .anywhere) {
log.warn("state transition to 'anywhere', likely bug: {x}", .{c}); log.debug(
"state transition to 'anywhere' from '{}', likely binary input: {x}",
.{ self.state, c },
);
} }
} }

6
src/terminal/parse_table.zig
View File

@ -38,7 +38,7 @@ fn genTableType() type {
const max_u8 = std.math.maxInt(u8); const max_u8 = std.math.maxInt(u8);
const stateInfo = @typeInfo(State); const stateInfo = @typeInfo(State);
const max_state = stateInfo.Enum.fields.len; const max_state = stateInfo.Enum.fields.len;
return [max_u8][max_state]Transition; return [max_u8 + 1][max_state]Transition;
} }
/// Function to generate the full state transition table for VT emulation. /// Function to generate the full state transition table for VT emulation.
@ -47,9 +47,9 @@ fn genTable() Table {
var result: Table = undefined; var result: Table = undefined;
// Initialize everything so every state transition exists // Initialize everything so every state transition exists
var i: u8 = 0; var i: usize = 0;
while (i < result.len) : (i += 1) { while (i < result.len) : (i += 1) {
var j: u8 = 0; var j: usize = 0;
while (j < result[0].len) : (j += 1) { while (j < result[0].len) : (j += 1) {
result[i][j] = transition(.anywhere, .none); result[i][j] = transition(.anywhere, .none);
} }