Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 08:16:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

selection: only clear when keypress has utf8

Browse Source 
Currently, the selection on a surface is cleared on any keypress that
generates a control sequence. For applications that enable kitty, this
can mean that every keypress clears the current selection thereby making
it impossible to copy text, since it will be cleared as soon as Control
is pressed. This can be very confusing to terminal users: some
applications I can shift+highlight and copy+paste, some I can't - and
unless I know the implementation of the application I won't know
why...very frustrating.

Only clear the selection when there is printable text, otherwise retain
the selection. From my testing, this makes text selection feel the same
between applications using kitty keyboard and applications that don't.
This commit is contained in:
Tim Culverhouse
2023-09-29 15:56:03 -05:00
parent 3bfcb010ef
commit 488e6670c2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Surface.zig
View File

@ -967,9 +967,9 @@ pub fn keyCallback(
}, .{ .forever = {} }); }, .{ .forever = {} });
try self.io_thread.wakeup.notify(); try self.io_thread.wakeup.notify();
// If we have a sequence to emit then we always want to clear the // If we have printable text to emit then we always want to clear the
// selection and scroll to the bottom. // selection and scroll to the bottom.
{ if (event.utf8.len > 0) {
self.renderer_state.mutex.lock(); self.renderer_state.mutex.lock();
defer self.renderer_state.mutex.unlock(); defer self.renderer_state.mutex.unlock();
self.setSelection(null); self.setSelection(null);