Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 00:06:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

always draw cell bg if it has one even if no char

Browse Source
This commit is contained in:
Mitchell Hashimoto
2022-05-12 16:46:05 -07:00
parent 89533f4754
commit 3a68d79d83
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/Grid.zig
View File

@ -275,24 +275,18 @@ pub fn updateCells(self: *Grid, term: Terminal) !void {
// Build each cell // Build each cell
for (term.screen.items) |line, y| { for (term.screen.items) |line, y| {
for (line.items) |cell, x| { for (line.items) |cell, x| {
// It can be zero if the cell is empty // If the cell has a background, we always draw it.
if (cell.empty()) continue;
// Get our glyph
// TODO: if we add a glyph, I think we need to rerender the texture.
const glyph = try self.font_atlas.addGlyph(self.alloc, cell.char);
if (cell.bg) |rgb| { if (cell.bg) |rgb| {
self.cells.appendAssumeCapacity(.{ self.cells.appendAssumeCapacity(.{
.mode = 1, .mode = 1,
.grid_col = @intCast(u16, x), .grid_col = @intCast(u16, x),
.grid_row = @intCast(u16, y), .grid_row = @intCast(u16, y),
.glyph_x = glyph.atlas_x, .glyph_x = 0,
.glyph_y = glyph.atlas_y, .glyph_y = 0,
.glyph_width = glyph.width, .glyph_width = 0,
.glyph_height = glyph.height, .glyph_height = 0,
.glyph_offset_x = glyph.offset_x, .glyph_offset_x = 0,
.glyph_offset_y = glyph.offset_y, .glyph_offset_y = 0,
.fg_r = 0, .fg_r = 0,
.fg_g = 0, .fg_g = 0,
.fg_b = 0, .fg_b = 0,
@ -304,6 +298,13 @@ pub fn updateCells(self: *Grid, term: Terminal) !void {
}); });
} }
// If the cell is empty then we draw nothing in the box.
if (cell.empty()) continue;
// Get our glyph
// TODO: if we add a glyph, I think we need to rerender the texture.
const glyph = try self.font_atlas.addGlyph(self.alloc, cell.char);
const fg = cell.fg orelse Terminal.RGB{ const fg = cell.fg orelse Terminal.RGB{
.r = 0xFF, .r = 0xFF,
.g = 0xA5, .g = 0xA5,