Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

selectionString: more accurate buf allocation

Browse Source
This commit is contained in:
Mitchell Hashimoto
2022-08-05 11:08:56 -07:00
parent 25dc292c14
commit 363c51360b
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/terminal/Screen.zig
View File

@ -406,12 +406,24 @@ pub fn selectionString(self: Screen, alloc: Allocator, sel: Selection) ![]const
// Get the slices for the string // Get the slices for the string
const slices = self.selectionSlices(sel); const slices = self.selectionSlices(sel);
// We can now know how much space we'll need to store the string. We // We can now know how much space we'll need to store the string. We loop
// can waste as much as 4x the size here as we make space for unicode // over and UTF8-encode and calculate the exact size required. We will be
// characters (which may take up 32 bits). // off here by at most "newlines" values in the worst case that every
// TODO: loop over and pre-calculate the sizeto avoid wasted space. // single line is soft-wrapped.
const newlines = @divFloor(slices.top.len + slices.bot.len, self.cols) + 1; const newlines = @divFloor(slices.top.len + slices.bot.len, self.cols) + 1;
const chars = (slices.top.len + slices.bot.len) * 4; const chars = chars: {
var count: usize = 0;
const arr = [_][]Cell{ slices.top, slices.bot };
for (arr) |slice| {
for (slice) |cell| {
var buf: [4]u8 = undefined;
const char = if (cell.char > 0) cell.char else ' ';
count += try std.unicode.utf8Encode(@intCast(u21, char), &buf);
}
}
break :chars count;
};
const buf = try alloc.alloc(u8, chars + newlines); const buf = try alloc.alloc(u8, chars + newlines);
var i: usize = 0; var i: usize = 0;