Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

Rename Split Horizontally/Vertically to Split Right/Down

Browse Source 
I make the following suggestion through a PR since I already tried this locally and have a branch ready:

- Rename Split Horizontally to Split Right
- Rename Split Vertically to Split Down

Rationale:

The terms horizontal and vertical are ambiguous in the context of splitting (does it mean the splitter is vertical, or are the panes organized vertically?)
Different apps pick different interpretations, so people get confused.

IntelliJ made the same change as above based on user feedback: https://youtrack.jetbrains.com/issue/IJPL-130991/Split-Vertically-and-Split-Horizontally-are-ambiguous-and-should-be-renamed

Ghostty is using the left/right nomenclature in other menu items. In the codebase, SplitDirection is already left/right.
This commit is contained in:
cryptocode
2024-05-10 11:17:11 +02:00
parent f410c9535f
commit 2faa0c9bee
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
macos/Sources/App/macOS/MainMenu.xib
View File

@ -126,16 +126,16 @@
</connections>
</menuItem>
<menuItem isSeparatorItem="YES" id="m54-Is-iLE"/>
<menuItem title="Split Horizontally" id="VUR-Ld-nLx">
<menuItem title="Split Right" id="VUR-Ld-nLx">
<modifierMask key="keyEquivalentModifierMask"/>
<connections>
<action selector="splitHorizontally:" target="-1" id="cv2-Xg-FR4"/>
<action selector="splitRight:" target="-1" id="cv2-Xg-FR4"/>
</connections>
</menuItem>
<menuItem title="Split Vertically" id="UDZ-4y-6xL">
<menuItem title="Split Down" id="UDZ-4y-6xL">
<modifierMask key="keyEquivalentModifierMask"/>
<connections>
<action selector="splitVertically:" target="-1" id="c6x-CF-u52"/>
<action selector="splitDown:" target="-1" id="c6x-CF-u52"/>
</connections>
</menuItem>
<menuItem isSeparatorItem="YES" id="sjq-M1-UGS"/>

4
macos/Sources/Features/Terminal/TerminalController.swift
View File

@ -461,12 +461,12 @@ class TerminalController: NSWindowController, NSWindowDelegate,
})
}
@IBAction func splitHorizontally(_ sender: Any) {
@IBAction func splitRight(_ sender: Any) {
guard let surface = focusedSurface?.surface else { return }
ghostty.split(surface: surface, direction: GHOSTTY_SPLIT_RIGHT)
}
@IBAction func splitVertically(_ sender: Any) {
@IBAction func splitDown(_ sender: Any) {
guard let surface = focusedSurface?.surface else { return }
ghostty.split(surface: surface, direction: GHOSTTY_SPLIT_DOWN)
}