From 28200fb9e5e0e54cbb075b9bd47357ea4f71a04a Mon Sep 17 00:00:00 2001 From: Qwerasd Date: Sun, 9 Feb 2025 17:45:00 -0500 Subject: [PATCH] fix(Metal): don't throw away glyphs when the fg and bg colors match This optimization is extremely niche and seems to be related to a strange bug experienced by Intel Mac users. Considering it costs some amount to have this extra check here even though it's false in the vast majority of cases, I feel it's pretty safe to just remove it entirely. --- src/renderer/shaders/cell.metal | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/renderer/shaders/cell.metal b/src/renderer/shaders/cell.metal index 5f161c6b7..e24ddcb1e 100644 --- a/src/renderer/shaders/cell.metal +++ b/src/renderer/shaders/cell.metal @@ -487,13 +487,6 @@ vertex CellTextVertexOut cell_text_vertex( ); } - // Don't bother rendering if the bg and fg colors are identical, just return - // the same point which will be culled because it makes the quad zero sized. - // However, we should still render if this is the cursor position - if (all(out.color == out.bg_color) && !is_cursor_pos) { - out.position = float4(0.0); - } - return out; }