Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-14 15:56:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix test error and improve error logging

Browse Source
This commit is contained in:
Jeffrey C. Ollie
2024-08-17 15:34:35 -05:00
parent b11b8be124
commit 254072e656
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/terminal/osc.zig
View File

@ -1038,15 +1038,24 @@ pub const Parser = struct {
switch (self.command) { switch (self.command) {
.kitty_color_protocol => |*v| { .kitty_color_protocol => |*v| {
if (kind == .key_only) { if (kind == .key_only) {
v.list.append(.{ .reset = key }) catch unreachable; v.list.append(.{ .reset = key }) catch |err| {
log.warn("unable to append kitty color protocol option: {}", .{err});
return;
};
return; return;
} }
if (value.len == 0) { if (value.len == 0) {
v.list.append(.{ .reset = key }) catch unreachable; v.list.append(.{ .reset = key }) catch |err| {
log.warn("unable to append kitty color protocol option: {}", .{err});
return;
};
return; return;
} }
if (mem.eql(u8, "?", value)) { if (mem.eql(u8, "?", value)) {
v.list.append(.{ .query = key }) catch unreachable; v.list.append(.{ .query = key }) catch |err| {
log.warn("unable to append kitty color protocol option: {}", .{err});
return;
};
return; return;
} }
v.list.append( v.list.append(
@ -1055,13 +1064,16 @@ pub const Parser = struct {
.key = key, .key = key,
.color = RGB.parse(value) catch |err| switch (err) { .color = RGB.parse(value) catch |err| switch (err) {
error.InvalidFormat => { error.InvalidFormat => {
log.err("invalid color format in kitty color protocol: {s}", .{value}); log.warn("invalid color format in kitty color protocol: {s}", .{value});
return; return;
}, },
}, },
}, },
}, },
) catch unreachable; ) catch |err| {
log.warn("unable to append kitty color protocol option: {}", .{err});
return;
};
return; return;
}, },
else => {}, else => {},
@ -1636,7 +1648,7 @@ test "OSC: hyperlink end" {
test "OSC: kitty color protocol" { test "OSC: kitty color protocol" {
const testing = std.testing; const testing = std.testing;
var p: Parser = .{ .alloc = std.testing.allocator }; var p: Parser = .{ .alloc = testing.allocator };
defer p.deinit(); defer p.deinit();
const input = "21;foreground=?;background=rgb:f0/f8/ff;cursor=aliceblue;cursor_text;visual_bell=;selection_foreground=#xxxyyzz;selection_background=?;selection_background=#aabbcc"; const input = "21;foreground=?;background=rgb:f0/f8/ff;cursor=aliceblue;cursor_text;visual_bell=;selection_foreground=#xxxyyzz;selection_background=?;selection_background=#aabbcc";