From 3497fec7dff5f4c6a7d0bb2ef13dccd967d77095 Mon Sep 17 00:00:00 2001 From: Severus Date: Wed, 8 Nov 2023 14:43:00 +0700 Subject: [PATCH 1/2] Add keymap for KP_* We miss some kp_* like: kp_home, kp_end, kp_up, kp_down, kp_page_up, kp_page_down, kp_left, kp_right. Then we map those keys in gtk runtime. --- src/apprt/gtk/key.zig | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/apprt/gtk/key.zig b/src/apprt/gtk/key.zig index 6f3a5cc81..d01fdaff3 100644 --- a/src/apprt/gtk/key.zig +++ b/src/apprt/gtk/key.zig @@ -189,6 +189,14 @@ const keymap: []const RawEntry = &.{ .{ c.GDK_KEY_KP_Add, .kp_add }, .{ c.GDK_KEY_KP_Enter, .kp_enter }, .{ c.GDK_KEY_KP_Equal, .kp_equal }, + .{ c.GDK_KEY_KP_Home, .home }, + .{ c.GDK_KEY_KP_End, .end }, + .{ c.GDK_KEY_KP_Page_Up, .page_up }, + .{ c.GDK_KEY_KP_Page_Down, .page_down }, + .{ c.GDK_KEY_KP_Up, .up }, + .{ c.GDK_KEY_KP_Down, .down }, + .{ c.GDK_KEY_KP_Right, .right }, + .{ c.GDK_KEY_KP_Left, .left }, .{ c.GDK_KEY_Shift_L, .left_shift }, .{ c.GDK_KEY_Control_L, .left_control }, From 0c695f3510b6d376945aa30977818588f1fb59c1 Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Wed, 8 Nov 2023 09:37:53 -0800 Subject: [PATCH 2/2] apprt/gtk: add comment about key aliases --- src/apprt/gtk/key.zig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/apprt/gtk/key.zig b/src/apprt/gtk/key.zig index d01fdaff3..2cd71eb1c 100644 --- a/src/apprt/gtk/key.zig +++ b/src/apprt/gtk/key.zig @@ -189,6 +189,9 @@ const keymap: []const RawEntry = &.{ .{ c.GDK_KEY_KP_Add, .kp_add }, .{ c.GDK_KEY_KP_Enter, .kp_enter }, .{ c.GDK_KEY_KP_Equal, .kp_equal }, + + // These are all just aliases to the non-kp variants because Ghostty + // core doesn't distinguish between them currently. .{ c.GDK_KEY_KP_Home, .home }, .{ c.GDK_KEY_KP_End, .end }, .{ c.GDK_KEY_KP_Page_Up, .page_up },