Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

config: macos-titlebar-style transparent disabled with light/dark mode

Browse Source
This commit is contained in:
Mitchell Hashimoto
2024-11-19 16:00:16 -08:00
parent 0e006dbd8d
commit 243b6f8c8d
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/config/Config.zig
View File

@ -1518,6 +1518,11 @@ keybind: Keybinds = .{},
/// but its one I think is the most aesthetically pleasing and works in /// but its one I think is the most aesthetically pleasing and works in
/// most cases. /// most cases.
/// ///
/// BUG: If a separate light/dark mode theme is configured with "theme",
/// then `macos-titlebar-style = transparent` will not work correctly. To
/// avoid ugly titlebars, `macos-titlebar-style` will become `native` if
/// a separate light/dark theme is configured.
///
/// Changing this option at runtime only applies to new windows. /// Changing this option at runtime only applies to new windows.
@"macos-titlebar-style": MacTitlebarStyle = .transparent, @"macos-titlebar-style": MacTitlebarStyle = .transparent,
@ -2728,10 +2733,16 @@ pub fn finalize(self: *Config) !void {
// If we have different light vs dark mode themes, disable // If we have different light vs dark mode themes, disable
// window-theme = auto since that breaks it. // window-theme = auto since that breaks it.
if (self.@"window-theme" == .auto and if (!std.mem.eql(u8, theme.light, theme.dark)) {
!std.mem.eql(u8, theme.light, theme.dark)) // This setting doesn't make sense with different light/dark themes
{ // because it'll force the theme based on the Ghostty theme.
self.@"window-theme" = .system; if (self.@"window-theme" == .auto) self.@"window-theme" = .system;
// This is buggy with different light/dark themes and is noted
// in the documentation.
if (self.@"macos-titlebar-style" == .transparent) {
self.@"macos-titlebar-style" = .native;
}
} }
} }