Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-23 12:16:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fully remove the redrawSurface API (#7991)

Browse Source 
This is a tiny addon from the recent gtk-ng work. We've moved redraw
requests into the apprt action system (the `render` action). I waited
until I had my macOS machine to verify that this fix could work. We can
now remove this completely.

We can probably remove the redraw inspector API too at some point but
I'm not there yet with the GTK backend so I'll just wait on it.
This commit is contained in:
Mitchell Hashimoto
2025-07-19 12:59:36 -07:00
committed by GitHub
parent 88b317dba3 7f0c247767
commit 1ec4383931
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/App.zig
View File

@ -293,14 +293,6 @@ fn redrawSurface(
) !void { ) !void {
if (!self.hasRtSurface(surface)) return; if (!self.hasRtSurface(surface)) return;
// TODO: Remove this in a separate PR. We should transition to
// the `render` apprt action completely. This is only to make
// our initial gtk-ng work touch less things.
if (@hasDecl(apprt.App, "redrawSurface")) {
rt_app.redrawSurface(surface);
return;
}
_ = try rt_app.performAction( _ = try rt_app.performAction(
.{ .surface = surface.core() }, .{ .surface = surface.core() },
.render, .render,

6
src/apprt/embedded.zig
View File

@ -249,12 +249,6 @@ pub const App = struct {
self.core_app.alloc.destroy(surface); self.core_app.alloc.destroy(surface);
} }
pub fn redrawSurface(self: *App, surface: *Surface) void {
_ = self;
_ = surface;
// No-op, we use a threaded interface so we're constantly drawing.
}
pub fn redrawInspector(self: *App, surface: *Surface) void { pub fn redrawInspector(self: *App, surface: *Surface) void {
_ = self; _ = self;
surface.queueInspectorRender(); surface.queueInspectorRender();