Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Mouse movement events are sent with shift until a button is pressed

Browse Source 
Ghostty was previously treating shift as a way to always stop mouse
reporting. That's true for mouse button events, but not for mouse
movement events. For mouse movement events, shift should be treated as
a modifier until a button (any mouse button) is pressed. Once it is
pressed, we pause mouse reporting until all buttons are released.

Found by @ldemailly. This matches the behavior of Kitty, Alacritty,
WezTerm, and xterm.
This commit is contained in:
Mitchell Hashimoto
2024-10-02 17:05:03 -07:00
parent 6940af2a16
commit 1d09cdb382
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Surface.zig
View File

@ -3040,8 +3040,13 @@ pub fn cursorPosCallback(
// Do a mouse report
if (self.io.terminal.flags.mouse_event != .none) report: {
// Shift overrides mouse "grabbing" in the window, taken from Kitty.
if (self.mouse.mods.shift and
!self.mouseShiftCapture(false)) break :report;
// This only applies if there is a mouse button pressed so that
// movement reports are not affected.
if (self.mouse.mods.shift and !self.mouseShiftCapture(false)) {
for (self.mouse.click_state) |state| {
if (state != .release) break :report;
}
}
// We use the first mouse button we find pressed in order to report
// since the spec (afaict) does not say...