From 1abc3ba1dae0d4d769151d2ed2a33cd79134ba9a Mon Sep 17 00:00:00 2001 From: "Jeffrey C. Ollie" Date: Tue, 8 Jul 2025 14:28:38 -0500 Subject: [PATCH] gtk: change child exited verbiage to be clearer and code cleanup --- src/apprt/gtk/Surface.zig | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/apprt/gtk/Surface.zig b/src/apprt/gtk/Surface.zig index 2cdfb45c9..a468bd48d 100644 --- a/src/apprt/gtk/Surface.zig +++ b/src/apprt/gtk/Surface.zig @@ -2510,10 +2510,10 @@ fn gtkStreamEnded(media_file: *gtk.MediaFile, _: *gobject.ParamSpec, _: ?*anyopa pub fn showChildExited(self: *Surface, info: apprt.surface.Message.ChildExited) error{}!bool { if (!adw_version.supportsBanner()) return false; - const warning_text = if (info.exit_code == 0) - i18n._("Process exited normally.") + const warning_text, const css_class = if (info.exit_code == 0) + .{ i18n._("Command succeeded"), "child_exited_normally" } else - i18n._("Process exited abnormally."); + .{ i18n._("Command failed"), "child_exited_abnormally" }; const banner = adw.Banner.new(warning_text); banner.setRevealed(1); @@ -2530,11 +2530,7 @@ pub fn showChildExited(self: *Surface, info: apprt.surface.Message.ChildExited) const banner_widget = banner.as(gtk.Widget); banner_widget.setHalign(.fill); banner_widget.setValign(.end); - - if (info.exit_code == 0) - banner_widget.addCssClass("child_exited_normally") - else - banner_widget.addCssClass("child_exited_abnormally"); + banner_widget.addCssClass(css_class); self.overlay.addOverlay(banner_widget);