Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 16:56:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

renderer: consider powerline box glyphs whitespace for PUA scaling

Browse Source 
This adds to the heuristics introduced for #1071. Please read that issue
and associated PRs in their entirety to understand this commit.

This extends our concept of "whitespace" to include powerline box
glyphs. We don't want to constrain nerd symbols next to powerline box
glyphs because box glyphs are often used to style and contain nerd
glyphs. For example, its common to see a right-facing semi-circle, then
a nerd font glyph, then a left-facing semi-circle to create a
pill-shaped label.

This allows those nerd font symbols to be rendered full size. Test
script below (copy the bytes):

    printf "󰃰\n"
    printf "󰃰 \n"
    printf "󰃰\n"
This commit is contained in:
Mitchell Hashimoto
2024-01-25 15:35:48 -08:00
parent a8b7ddbc88
commit 1907c58972
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/renderer/cell.zig
View File

@ -58,8 +58,14 @@ pub fn fgMode(
// If we have a previous cell and it was PUA then we need to
// also constrain. This is so that multiple PUA glyphs align.
if (x > 0) {
// As an exception, we ignore powerline glyphs since they are
// used for box drawing and we consider them whitespace.
if (x > 0) prev: {
const prev_cell = screen.getCell(.active, y, x - 1);
// Powerline is whitespace
if (isPowerline(prev_cell.char)) break :prev;
if (ziglyph.general_category.isPrivateUse(@intCast(prev_cell.char))) {
break :text .constrained;
}
@ -68,7 +74,10 @@ pub fn fgMode(
// If the next cell is empty, then we allow it to use the
// full glyph size.
const next_cell = screen.getCell(.active, y, x + 1);
if (next_cell.char == 0 or next_cell.char == ' ') {
if (next_cell.char == 0 or
next_cell.char == ' ' or
isPowerline(next_cell.char))
{
break :text .normal;
}