Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-08-02 14:57:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add delay before a title change to avoid flicker on macOS

Browse Source
This commit is contained in:
Pranav Mangal
2024-12-11 23:10:03 +05:30
parent 9f75d93a55
commit 146b1f2a1b
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
macos/Sources/Features/Terminal/BaseTerminalController.swift
View File

@ -54,6 +54,10 @@ class BaseTerminalController: NSWindowController,
/// Fullscreen state management. /// Fullscreen state management.
private(set) var fullscreenStyle: FullscreenStyle? private(set) var fullscreenStyle: FullscreenStyle?
var titleChangeDelay: TimeInterval = 0.075
private var titleChangeTimer: Timer?
/// Event monitor (see individual events for why) /// Event monitor (see individual events for why)
private var eventMonitor: Any? = nil private var eventMonitor: Any? = nil
@ -260,9 +264,12 @@ class BaseTerminalController: NSWindowController,
func titleDidChange(to: String) { func titleDidChange(to: String) {
guard let window else { return } guard let window else { return }
// Set the main window title titleChangeTimer?.invalidate()
window.title = to
// Set the main window title after a small delay to prevent flicker
titleChangeTimer = Timer.scheduledTimer(withTimeInterval: titleChangeDelay, repeats: false) { _ in
window.title = to
}
} }
func pwdDidChange(to: URL?) { func pwdDidChange(to: URL?) {

8
macos/Sources/Features/Terminal/TerminalController.swift
View File

@ -27,6 +27,8 @@ class TerminalController: BaseTerminalController {
/// The notification cancellable for focused surface property changes. /// The notification cancellable for focused surface property changes.
private var surfaceAppearanceCancellables: Set<AnyCancellable> = [] private var surfaceAppearanceCancellables: Set<AnyCancellable> = []
private var toolbarTitleChangeTimer: Timer?
init(_ ghostty: Ghostty.App, init(_ ghostty: Ghostty.App,
withBaseConfig base: Ghostty.SurfaceConfiguration? = nil, withBaseConfig base: Ghostty.SurfaceConfiguration? = nil,
withSurfaceTree tree: Ghostty.SplitNode? = nil withSurfaceTree tree: Ghostty.SplitNode? = nil
@ -546,9 +548,15 @@ class TerminalController: BaseTerminalController {
// a custom view instead, we need to re-hide it. // a custom view instead, we need to re-hide it.
window.titleVisibility = .hidden window.titleVisibility = .hidden
} }
toolbarTitleChangeTimer?.invalidate()
// Set the toolbar title after a small delay to prevent flicker
toolbarTitleChangeTimer = Timer.scheduledTimer(withTimeInterval: titleChangeDelay, repeats: false) { _ in
toolbar.titleText = to toolbar.titleText = to
} }
} }
}
override func surfaceTreeDidChange() { override func surfaceTreeDidChange() {
// Whenever our surface tree changes in any way (new split, close split, etc.) // Whenever our surface tree changes in any way (new split, close split, etc.)