From 0a37fa42e6b6f5a1c99658bf30c820fdbffb2fa5 Mon Sep 17 00:00:00 2001
From: pnodet <paul.nodet@gmail.com>
Date: Sun, 29 Dec 2024 02:45:48 +0100
Subject: [PATCH] fix: replace getLast by pop

---
 src/apprt/glfw.zig          | 2 +-
 src/terminal/closedtabs.zig | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/apprt/glfw.zig b/src/apprt/glfw.zig
index 94d6d8720..ad0548c3a 100644
--- a/src/apprt/glfw.zig
+++ b/src/apprt/glfw.zig
@@ -364,7 +364,7 @@ pub const App = struct {
         };
 
         // Get the last closed tab from the app-level storage
-        const last_tab: *LastClosedTab = parent.app.last_closed_tabs.getLast() orelse {
+        const last_tab: LastClosedTab = parent.app.last_closed_tabs.pop() orelse {
             log.warn("No last closed tab found", .{});
             return;
         };
diff --git a/src/terminal/closedtabs.zig b/src/terminal/closedtabs.zig
index 06b9b4063..7744c97f4 100644
--- a/src/terminal/closedtabs.zig
+++ b/src/terminal/closedtabs.zig
@@ -48,8 +48,10 @@ pub const LastClosedTabs = struct {
         return self.this.len;
     }
 
-    pub fn getLast(self: *LastClosedTabs) ?*LastClosedTab {
+    pub fn pop(self: *LastClosedTabs) ?LastClosedTab {
         if (self.this.len == 0) return null;
-        return &self.this.buffer[self.this.len - 1];
+        const last = self.this.buffer[self.this.len - 1];
+        self.this.len -= 1;
+        return last;
     }
 };