Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-16 08:46:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

gtk: comment out detach-tab feature after breaking it

Browse Source
This commit is contained in:
Thorsten Ball
2023-11-01 08:23:20 +01:00
committed by Mitchell Hashimoto
parent 7cad9a253e
commit 09bbaa82b4
1 changed files with 20 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
src/apprt/gtk/Window.zig
View File

@ -437,27 +437,31 @@ fn gtkNotebookCreateWindow(
page: *c.GtkWidget, page: *c.GtkWidget,
ud: ?*anyopaque, ud: ?*anyopaque,
) callconv(.C) ?*c.GtkNotebook { ) callconv(.C) ?*c.GtkNotebook {
_ = ud;
_ = page;
log.warn("feature needs to be re-implemented after adding gtk splits", .{});
return null;
// The tab for the page is stored in the widget data. // The tab for the page is stored in the widget data.
const tab: *Tab = @ptrCast(@alignCast( // const tab: *Tab = @ptrCast(@alignCast(
c.g_object_get_data(@ptrCast(page), Tab.GHOSTTY_TAB) orelse return null, // c.g_object_get_data(@ptrCast(page), Tab.GHOSTTY_TAB) orelse return null,
)); // ));
const surface: *Surface = tab.focus_child; // const surface: *Surface = tab.focus_child;
const self = userdataSelf(ud.?); // const self = userdataSelf(ud.?);
const alloc = self.app.core_app.alloc; // const alloc = self.app.core_app.alloc;
// Create a new window // // Create a new window
const window = Window.create(alloc, self.app) catch |err| { // const window = Window.create(alloc, self.app) catch |err| {
log.warn("error creating new window error={}", .{err}); // log.warn("error creating new window error={}", .{err});
return null; // return null;
}; // };
// We need to update our surface to point to the new window and tab so that // // We need to update our surface to point to the new window and tab so that
// events such as new tab go to the right window. // // events such as new tab go to the right window.
surface.window = window; // surface.window = window;
surface.tab = window.tabs.items[window.tabs.items.len - 1]; // surface.tab = window.tabs.items[window.tabs.items.len - 1];
return window.notebook; // return window.notebook;
} }
fn gtkCloseRequest(v: *c.GtkWindow, ud: ?*anyopaque) callconv(.C) bool { fn gtkCloseRequest(v: *c.GtkWindow, ud: ?*anyopaque) callconv(.C) bool {