Applied-Software/ghostty
5
0
Fork 0
mirror of https://github.com/ghostty-org/ghostty.git synced 2025-07-15 16:26:08 +03:00
Code Issues Packages Projects Releases Wiki Activity

validate locale prior to setting, fallback to en_US.UTF-8

Browse Source 
Fixes #201

I don't fully understand locales, but it appears that the locale
returned from NSLocale can be "valid" in general but invalid according
to libc's locale API. If you attempt to `setlocale` with this bad
locale, it defaults everything to "C", which ends up breaking a lot of
things.

This commit validates the locale, and if it is invalid, we default to
"en_US.UTF-8" so things tend to work. This behavior can be overridden
using standard environment variables (LANG, LC_ALL, etc.).

This also doesn't touch env vars so further subprocesses from the shell
see original locale env vars.
This commit is contained in:
Mitchell Hashimoto
2023-07-11 11:50:12 -07:00
parent bf25bf0a6a
commit 0849aa8f20
1 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/os/locale.zig
View File

@ -25,12 +25,35 @@ pub fn ensureLocale() void {
} }
} }
// If we have a locale set in the env, we verify it is valid. If it isn't
// valid, then we set it to a default value of en_US.UTF-8. We don't touch
// the existing LANG value in the env so that child processes can use it,
// though.
const locale: []const u8 = locale: {
// If we don't have lang set, we use "" and let the default happen.
const lang = std.os.getenv("LANG") orelse break :locale "";
// If the locale is valid, we also use "" because LANG is already set.
if (localeIsValid(lang)) break :locale "";
log.info("LANG is not valid according to libc, will use en_US.UTF-8", .{});
break :locale "en_US.UTF-8";
};
// Set the locale // Set the locale
if (setlocale(LC_ALL, "")) |locale| { if (setlocale(LC_ALL, locale.ptr)) |v| {
log.debug("setlocale result={s}", .{locale}); log.debug("setlocale result={s}", .{v});
} else log.warn("setlocale failed, locale may be incorrect", .{}); } else log.warn("setlocale failed, locale may be incorrect", .{});
} }
/// Returns true if the given locale is valid according to libc. This value
/// can be `en_US` or `en_US.utf-8` style of formatting.
fn localeIsValid(locale: []const u8) bool {
const v = newlocale(LC_ALL_MASK, locale.ptr, null) orelse return false;
defer freelocale(v);
return true;
}
/// This sets the LANG environment variable based on the macOS system /// This sets the LANG environment variable based on the macOS system
/// preferences selected locale settings. /// preferences selected locale settings.
fn setLangFromCocoa() void { fn setLangFromCocoa() void {
@ -87,5 +110,9 @@ fn setLangFromCocoa() void {
} }
const LC_ALL: c_int = 6; // from locale.h const LC_ALL: c_int = 6; // from locale.h
extern "c" fn setlocale(category: c_int, locale: ?[*]const u8) ?[*:0]u8; const LC_ALL_MASK: c_int = 0x7fffffff; // from locale.h
const locale_t = ?*anyopaque;
extern "c" fn setenv(name: ?[*]const u8, value: ?[*]const u8, overwrite: c_int) c_int; extern "c" fn setenv(name: ?[*]const u8, value: ?[*]const u8, overwrite: c_int) c_int;
extern "c" fn setlocale(category: c_int, locale: ?[*]const u8) ?[*:0]u8;
extern "c" fn newlocale(category: c_int, locale: ?[*]const u8, base: locale_t) locale_t;
extern "c" fn freelocale(v: locale_t) void;